-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation to verify account action and update swagger.yml #555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. It would be great if you could improve the code in some ways.
spec/Validator/Customer/VerificationTokenExistsValidatorSpec.php
Outdated
Show resolved
Hide resolved
spec/Validator/Customer/VerificationTokenExistsValidatorSpec.php
Outdated
Show resolved
Hide resolved
|
||
namespace Sylius\ShopApiPlugin\Validator\Customer; | ||
|
||
use Sylius\Component\User\Repository\UserRepositoryInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the interface from the core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only this interface. Do you mean the class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a core interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know which one you mean. The UserRepositoryInterface
from the user component is the only one, I have found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, my bad.
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
Thank you, @CSchulz! 🎉 |
No description provided.